HTML API: Reconsume script data less-than tokens#56
Open
sirreal wants to merge 1 commit into
Open
Conversation
sirreal
changed the title
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Updates
WP_HTML_Tag_Processor::skip_script_data()so a non-matching byte after<in script data is reconsumed instead of skipped.Adds regression coverage for
normalize()and tag parsing cases such as<script><</script>and<script></</script>, plus related less-than sequences before the real closer.Why
The parser was advancing past the byte after
<when the sequence was not a script end tag. If that byte was itself another<starting the real</script>closer, the parser skipped over the closer and later reported the document as paused at an incomplete token.normalize()then dropped the script element.Validation
WP_TESTS_SKIP_INSTALL=1 ./vendor/bin/phpunit --group html-api --filter 'test_special_text_less_than_sequences_before_closer_are_not_incomplete|test_script_tag_parsing'-> OK, 45 tests, 83 assertions./vendor/bin/phpcs --standard=phpcs.xml.dist src/wp-includes/html-api/class-wp-html-tag-processor.php tests/phpunit/tests/html-api/wpHtmlProcessor-serialize.php tests/phpunit/tests/html-api/wpHtmlTagProcessor.php-> OKWP_TESTS_SKIP_INSTALL=1 ./vendor/bin/phpunit --group html-api,html-api-html5lib-tests-> OK, 2917 tests, 6182 assertions, 421 skipped